[Enhancement✨] Add buyer_id_ref method for MessageTrait by slegarraga · Pull Request #6616 · mxsm/rocketmq-rust

slegarraga · 2026-03-01T13:51:54Z

Motivation

Modification

Added buyer_id_ref() method to MessageTrait that returns Option<&CheetahString> instead of cloning. This is consistent with existing _ref methods like tags_ref(), get_keys_ref(), and user_property_ref().

Result

Zero-copy access to buyer ID property, avoiding unnecessary string cloning.

Summary by CodeRabbit

New Features
- Enhanced buyer ID property access in the messaging system, allowing more efficient retrieval and handling of buyer information data.

Add buyer_id_ref() method that returns Option<&CheetahString> instead of cloning, consistent with existing _ref methods (tags_ref, get_keys_ref, user_property_ref). Closes mxsm#6588

rocketmq-rust-bot · 2026-03-01T13:52:03Z

🔊@slegarraga 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

coderabbitai · 2026-03-01T13:52:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c59f59 and 67f71b5.

📒 Files selected for processing (1)

rocketmq-common/src/common/message.rs

Walkthrough

A new method buyer_id_ref() was added to the MessageTrait trait, providing a reference accessor for the buyer ID property that returns Option<&CheetahString>. The method uses the existing property_ref() mechanism alongside the current buyer_id() default implementation.

Changes

Cohort / File(s)	Summary
New Trait Method `rocketmq-common/src/common/message.rs`	Added `buyer_id_ref(&self) -> Option<&CheetahString>` method to `MessageTrait`, offering a reference-based accessor for the buyer ID property.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A reference so clean, a method so small,
The buyer_id_ref now answers the call,
No clone, no copy, just borrow with care,
A rabbit's addition, light as the air! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a buyer_id_ref method to MessageTrait.
Linked Issues check	✅ Passed	The pull request fully implements the requirement from issue `#6588`: adding buyer_id_ref method returning Option<&CheetahString> to MessageTrait.
Out of Scope Changes check	✅ Passed	All changes are directly related to the linked issue `#6588`; only the buyer_id_ref method was added with no extraneous modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-01T13:59:58Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.34%. Comparing base (c803c98) to head (67f71b5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
rocketmq-common/src/common/message.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6616      +/-   ##
==========================================
- Coverage   41.52%   41.34%   -0.19%     
==========================================
  Files         961      963       +2     
  Lines      134645   135226     +581     
==========================================
- Hits        55909    55906       -3     
- Misses      78736    79320     +584

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rocketmq-rust-bot

LGTM - All CI checks passed ✅

mxsm

LGTM

[Enhancement✨] Add buyer_id_ref method for MessageTrait

67f71b5

Add buyer_id_ref() method that returns Option<&CheetahString> instead of cloning, consistent with existing _ref methods (tags_ref, get_keys_ref, user_property_ref). Closes mxsm#6588

rocketmq-rust-bot requested review from TeslaRustor, mxsm and rocketmq-rust-bot March 1, 2026 13:52

rocketmq-rust-bot added AI review first Ai review pr first auto merge ready to review waiting-review waiting review this PR labels Mar 1, 2026

rocketmq-rust-robot added Difficulty level/Easy Easy ISSUE enhancement✨ labels Mar 1, 2026

rocketmq-rust-bot approved these changes Mar 1, 2026

View reviewed changes

mxsm approved these changes Mar 1, 2026

View reviewed changes

mxsm merged commit da0bba5 into mxsm:main Mar 1, 2026
10 of 21 checks passed

rocketmq-rust-bot added approved PR has approved and removed ready to review waiting-review waiting review this PR labels Mar 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhancement✨] Add buyer_id_ref method for MessageTrait#6616

[Enhancement✨] Add buyer_id_ref method for MessageTrait#6616
mxsm merged 1 commit intomxsm:mainfrom
slegarraga:feat-6588

slegarraga commented Mar 1, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

rocketmq-rust-bot commented Mar 1, 2026

Uh oh!

coderabbitai bot commented Mar 1, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 1, 2026 •

edited

Loading

Uh oh!

rocketmq-rust-bot left a comment

Uh oh!

mxsm left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

slegarraga commented Mar 1, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Modification

Result

Summary by CodeRabbit

Uh oh!

rocketmq-rust-bot commented Mar 1, 2026

Uh oh!

coderabbitai bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

codecov bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rocketmq-rust-bot left a comment

Choose a reason for hiding this comment

Uh oh!

mxsm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

slegarraga commented Mar 1, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 1, 2026 •

edited

Loading

codecov bot commented Mar 1, 2026 •

edited

Loading